fix(installer): WiX uninstall script paths - #121
Merged
Conversation
Resolve WiX driver uninstall actions to use the Windows folder and the packaged script file id instead of the install root path. This keeps deferred uninstall actions working when the install root is configurable or the installer is patched. The template also adds the WindowsFolder standard directory, and the Windows driver docs now describe the selected install root instead of the hardcoded default path.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 73.38% 73.34% -0.05%
==========================================
Files 34 34
Lines 9235 9235
Branches 3439 3439
==========================================
- Hits 6777 6773 -4
- Misses 1794 2138 +344
+ Partials 664 324 -340
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve WiX driver uninstall actions to use the Windows folder and the packaged script file id instead of the install root path. This keeps deferred uninstall actions working when the install root is configurable or the installer is patched. The template also adds the WindowsFolder standard directory, and the Windows driver docs now describe the selected install root instead of the hardcoded default path.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.